Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: image tagging consistency #313

Merged
merged 7 commits into from
Mar 9, 2023
Merged

fix: image tagging consistency #313

merged 7 commits into from
Mar 9, 2023

Conversation

rokroskar
Copy link
Member

Following the Makefile refactoring there were some issues with image tags - this PR sets up a consistent use of DOCKER_LABEL and other environment variables.

@rokroskar rokroskar marked this pull request as draft March 1, 2023 15:58
@rokroskar rokroskar marked this pull request as ready for review March 1, 2023 16:26
@rokroskar rokroskar requested a review from a team March 1, 2023 17:06
@rokroskar rokroskar changed the title fix: ensure consistency with DOCKER_LABEL fix: image tagging consistency Mar 2, 2023
@rokroskar rokroskar mentioned this pull request Mar 8, 2023
Merged
seanrmurphy
seanrmurphy approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@seanrmurphy seanrmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing by setting up different configurations of env vars and seeing if the images were tagged correctly. I did this for the python, R and julia images - everything worked as expected.

@rokroskar
Copy link
Member Author

Thanks for the careful review @seanrmurphy !

@rokroskar rokroskar merged commit e6c1294 into master Mar 9, 2023
@rokroskar rokroskar deleted the 000-fix-build branch March 9, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanrmurphy seanrmurphy seanrmurphy approved these changes

@Panaetius Panaetius Awaiting requested review from Panaetius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokroskar @seanrmurphy