chore: library upgrade #251
Conversation
Since jupyterlab is already included in the base base image it should be possible to use this version instead of installing an older version afterwards.
|
@olevski @gavin-k-lee a bunch of things are changed here in these images so it would be great if you could give them a once-over. They seem fine to me. Note also that since the default python version in the latest |
Co-authored-by: Lorenzo Cavazzi <[email protected]>
|
According to https://docs.python.org/3/whatsnew/3.9.html#you-should-check-for-deprecationwarning-in-your-code 3.9 is the last version to contain 2.7 backwards compatibility layer and https://docs.python.org/3/whatsnew/3.10.html#removed did in fact remove some module methods and quite a lot of C API functions/types (at the end of the page). So 3.10 probably has a bit higher chance of breaking things than was the case with 3.9 We do NOT have tests for 3.10 in renku-python, so upgrading to 3.10 would essentially be flying blind, plus the higher risk of breaking user code does mean it'd make sense to upgrade to a version prior to https://github.com/jupyter/docker-stacks/blame/0be9e335026b21a452c888481ab6341dcdd183a5/base-notebook/Dockerfile#L88 |
|
Something is wrong with the |
| @@ -62,7 +62,7 @@ jobs: | |||
|
|
|||
| # This ensures the same image tags as before are built, in addition to new ones | |||
| if [[ "${{ matrix.BASE_IMAGE_TAG }}" == lab-* ]]; then | |||
| export LABEL_PREFIX=3.9 | |||
| export LABEL_PREFIX=3.10 | |||
There was a problem hiding this comment.
@rokroskar I thought none of the images are using python 3.10. And from Ralf's comment it seems we are not ready for 3.10 yet.
So this should then probably be rolled back to 3.9?
There was a problem hiding this comment.
| export LABEL_PREFIX=3.10 | |
| export LABEL_PREFIX=3.9 |
| @@ -356,7 +356,7 @@ jobs: | |||
|
|
|||
| export DOCKER_TAG="${{ matrix.JULIAVERSIONS }}-$LABEL" | |||
| docker build docker/julia \ | |||
| --build-arg BASE_IMAGE="$DOCKER_NAME-py:3.9-$LABEL" \ | |||
| --build-arg BASE_IMAGE="$DOCKER_NAME-py:3.10-$LABEL" \ | |||
There was a problem hiding this comment.
| --build-arg BASE_IMAGE="$DOCKER_NAME-py:3.10-$LABEL" \ | |
| --build-arg BASE_IMAGE="$DOCKER_NAME-py:3.9-$LABEL" \ |
| @@ -408,11 +408,11 @@ jobs: | |||
|
|
|||
| export DOCKER_TAG="${{ matrix.RVERSION }}-$LABEL" | |||
| docker build docker/r \ | |||
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.9-$LABEL" \ | |||
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.10-$LABEL" \ | |||
There was a problem hiding this comment.
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.10-$LABEL" \ | |
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.9-$LABEL" \ |
| @@ -462,7 +462,7 @@ jobs: | |||
|
|
|||
| export DOCKER_TAG="${{ matrix.RELEASE }}-$LABEL" | |||
| docker build docker/r \ | |||
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.9-$LABEL" \ | |||
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.10-$LABEL" \ | |||
There was a problem hiding this comment.
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.10-$LABEL" \ | |
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.9-$LABEL" \ |
| @@ -320,8 +320,8 @@ jobs: | |||
| fi | |||
|
|
|||
| docker build docker/batch \ | |||
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.9-$LABEL" \ | |||
| --build-arg BASE_IMAGE="python:3.9-slim-buster" \ | |||
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.10-$LABEL" \ | |||
There was a problem hiding this comment.
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.10-$LABEL" \ | |
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.9-$LABEL" \ |
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.9-$LABEL" \ | ||
| --build-arg BASE_IMAGE="python:3.9-slim-buster" \ | ||
| --build-arg RENKU_BASE="$DOCKER_NAME-py:3.10-$LABEL" \ | ||
| --build-arg BASE_IMAGE="python:3.10-slim-buster" \ |
There was a problem hiding this comment.
| --build-arg BASE_IMAGE="python:3.10-slim-buster" \ | |
| --build-arg BASE_IMAGE="python:3.9-slim-buster" \ |
| @@ -114,7 +114,7 @@ jobs: | |||
| fi | |||
|
|
|||
| docker build docker/$EXTENSION \ | |||
| --build-arg BASE_IMAGE="$DOCKER_NAME-py:3.9-$LABEL" \ | |||
| --build-arg BASE_IMAGE="$DOCKER_NAME-py:3.10-$LABEL" \ | |||
There was a problem hiding this comment.
| --build-arg BASE_IMAGE="$DOCKER_NAME-py:3.10-$LABEL" \ | |
| --build-arg BASE_IMAGE="$DOCKER_NAME-py:3.9-$LABEL" \ |
upgrades the libraries pinned in the base image.