Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renku not found error #193

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Fix renku not found error #193

merged 2 commits into from
Nov 15, 2021

Conversation

TaoSunVoyage
Copy link
Contributor

#187 changed where renku is installed.

renku is now in either $HOME/.renku/bin or /share/bin (batch)

#187 changed where renku is installed.

renku is now in either `$HOME/.renku/bin` or `/share/bin` (batch)
@TaoSunVoyage TaoSunVoyage requested a review from ableuler October 12, 2021 16:08
Copy link
Contributor

@ableuler ableuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouh, nasty one - good catch!

@TaoSunVoyage TaoSunVoyage enabled auto-merge (squash) November 11, 2021 13:23
@ableuler
Copy link
Contributor

@TaoSunVoyage this is an important fix of yours that should be merged asap. Could you please follow up on it and make sure it goes in? 🙏

@TaoSunVoyage
Copy link
Contributor Author

@ableuler sure, I am checking why the checks failed

@ableuler
Copy link
Contributor

Ah, I just realise that the tests are failing here because #197 is not yet merged.

@TaoSunVoyage TaoSunVoyage merged commit 02cb140 into master Nov 15, 2021
@TaoSunVoyage TaoSunVoyage deleted the 000-renku-unfound branch November 15, 2021 22:41
TaoSunVoyage added a commit that referenced this pull request Nov 16, 2021
renku is now in either `$HOME/.renku/bin` or `/share/bin` (batch)
TaoSunVoyage added a commit that referenced this pull request Nov 17, 2021
renku is now in either `$HOME/.renku/bin` or `/share/bin` (batch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants