Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rstudio version #179

Closed
wants to merge 4 commits into from
Closed

Conversation

olevski
Copy link
Member

@olevski olevski commented Aug 5, 2021

I still have to test this to see if it works and fixes the issue reported here:
https://renku.discourse.group/t/rstudio-version-too-old/393

@olevski
Copy link
Member Author

olevski commented Aug 5, 2021

No luck with a quick PR. Rstudio does not start with this change. So we need to do some troubleshooting.

@olevski olevski marked this pull request as draft August 5, 2021 11:25
@TaoSunVoyage
Copy link
Contributor

this is related to #154 and #160

@ableuler ableuler marked this pull request as ready for review August 22, 2021 20:10
ableuler
ableuler previously approved these changes Aug 22, 2021
Copy link
Contributor

@ableuler ableuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I can tell from running the resulting image locally, this should solve the problem reported in the discourse post.

@TaoSunVoyage
Copy link
Contributor

TaoSunVoyage commented Aug 23, 2021

thanks @ableuler.

Bioconductor 3.13 requires R 4.1.0, which can only work in RStudio 1.4 #160. However, there are still some issues with jupyter-rsession-proxy. Although it works locally, this extension doesn't seem to function very well in JupyterHub (see my comments here)

@ableuler
Copy link
Contributor

thanks @ableuler.

Bioconductor 3.13 requires R 4.1.0, which can only work in RStudio 1.4 #160. However, there are still some issues with jupyter-rsession-proxy. Although it works locally, this extension doesn't seem to function very well in JupyterHub (see my comments here)

Ah sorry, hadn't seen your comment on the issue. I just had a quick look why acceptance tests on this PR were failing and fixed it by adjusting the www-root-path manually or setting RSESSION_PROXY_RSTUDIO_1_4=true respectively.

@rokroskar
Copy link
Member

So does this work or not?

@TaoSunVoyage
Copy link
Contributor

So does this work or not?

not yet

Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make sure it works :)

@rokroskar
Copy link
Member

ok - I was confused by all the green and was tempted to push the merge button 😆

@ableuler
Copy link
Contributor

Yeah - I think in the light of recent events and our future plans for Rstudio sessions in renkulab.io, I'd suggest to close this PR altogether.

@olevski olevski closed this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants