-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vnc upgrades #156
feat: vnc upgrades #156
Conversation
The updated iteration looks like the following: It can be spun up at https://renkulab.io/gitlab/lee.gavin.k/blank. |
Due to the rebranding, this closes #151 |
Interesting... I was able to replicate. I was using Chrome and it works fine when resizing. I'll look into it. |
Nice - would it make sense to have additional |
From my understanding of the development plan, the idea is to have those buttons available from the UI, where the jupyter lab session is embedded in an iframe. However a second step could be to have buttons in the VNC drop-down tab that are aliases for the buttons in the UI. Thoughts? |
@rokroskar I believe that's fixed on firefox now. |
@gavin-k-lee @erbou I think adding those buttons to the VNC could be a possibility, but we should discuss this with the UI team and do a proper design of what the buttons should do and how. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified that the sizing problem is gone - thanks!
closes #152