Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vnc upgrades #156

Merged
merged 4 commits into from
May 19, 2021
Merged

feat: vnc upgrades #156

merged 4 commits into from
May 19, 2021

Conversation

gavin-k-lee
Copy link
Contributor

  • adds clipboard feature to VNC
  • removes top bar to give more screen real-estate
  • removes some unneeded functionality in the 'full' noVNC
  • rebrands some features to renku (favicon, HTML title)
  • removes annoying 'bell' sound in vnc terminal

closes #152

@gavin-k-lee
Copy link
Contributor Author

The updated iteration looks like the following:

image

It can be spun up at https://renkulab.io/gitlab/lee.gavin.k/blank.

@gavin-k-lee gavin-k-lee marked this pull request as ready for review May 18, 2021 09:26
@gavin-k-lee gavin-k-lee requested review from rokroskar and ciyer May 18, 2021 09:26
@gavin-k-lee
Copy link
Contributor Author

Due to the rebranding, this

closes #151

@gavin-k-lee gavin-k-lee linked an issue May 18, 2021 that may be closed by this pull request
@rokroskar
Copy link
Member

for some reason the desktop size is not automatically scaled to the browser window for me:

image

Using firefox

@gavin-k-lee
Copy link
Contributor Author

gavin-k-lee commented May 18, 2021

Interesting... I was able to replicate. I was using Chrome and it works fine when resizing. I'll look into it.

@erbou
Copy link

erbou commented May 18, 2021

Nice - would it make sense to have additional renku features next to the clipboard features? I am thinking of a renku save, but there could be others (indicators of status, such as unsaved work and actions).

@gavin-k-lee
Copy link
Contributor Author

gavin-k-lee commented May 18, 2021

Nice - would it make sense to have additional renku features next to the clipboard features? I am thinking of a renku save, but there could be others (indicators of status, such as unsaved work and actions).

From my understanding of the development plan, the idea is to have those buttons available from the UI, where the jupyter lab session is embedded in an iframe. However a second step could be to have buttons in the VNC drop-down tab that are aliases for the buttons in the UI. Thoughts?

@gavin-k-lee
Copy link
Contributor Author

@rokroskar I believe that's fixed on firefox now.

@rokroskar
Copy link
Member

@gavin-k-lee @erbou I think adding those buttons to the VNC could be a possibility, but we should discuss this with the UI team and do a proper design of what the buttons should do and how.

Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified that the sizing problem is gone - thanks!

@gavin-k-lee gavin-k-lee merged commit cc2b9ad into master May 19, 2021
@gavin-k-lee gavin-k-lee deleted the 000-vnc-upgrade branch May 19, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipboard (Ctrl+C/V) support in the VNC branding: rename noVNC
3 participants