Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: do the jupyter build at the end of vscode script #139

Merged
merged 2 commits into from
Feb 10, 2021
Merged

chore: do the jupyter build at the end of vscode script #139

merged 2 commits into from
Feb 10, 2021

Conversation

rokroskar
Copy link
Member

@rokroskar rokroskar commented Feb 10, 2021 •
edited
Loading

avoid jupyter rebuilds on session launch and bump vscode version

you can test it here: https://dev.renku.ch/projects/rokroskar/test-vscode/environments/new (just select /lab before launching)

@rokroskar rokroskar changed the title chore: do the jupyter build at the end chore: do the jupyter build at the end of vscode script Feb 10, 2021
@rokroskar rokroskar marked this pull request as ready for review February 10, 2021 15:39
pameladelgado
pameladelgado approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@pameladelgado pameladelgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokroskar rokroskar merged commit 991e99e into master Feb 10, 2021
@rokroskar rokroskar deleted the rokroskar-patch-1 branch February 10, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pameladelgado pameladelgado pameladelgado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokroskar @pameladelgado