add search fix to user facing changes #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lokijuhy
commented
Oct 8, 2024
lokijuhy
commented
- note the search fix in the user facing changes section
- some minor wordsmithing
Panaetius
requested changes
Oct 8, 2024
CHANGELOG.rst
Outdated
| @@ -3,6 +3,10 @@ | |||
| 0.58.0 | |||
| ------ | |||
|
|
|||
| Renku ``0.57.2`` fixes several issues related to Renku 2.0 search, and also squashes a bug where the | |||
There was a problem hiding this comment.
Suggested change
| Renku ``0.57.2`` fixes several issues related to Renku 2.0 search, and also squashes a bug where the | |
| Renku ``0.58.0`` fixes several issues related to Renku 2.0 search, and also squashes a bug where the |
CHANGELOG.rst
Outdated
| @@ -12,9 +16,10 @@ User-Facing Changes | |||
|
|
|||
| **🐞 Bug Fixes** | |||
|
|
|||
| - **Search Services**: Resolve issues that caused items to be missing from Renku 2.0 search, including the in the search for adding members to projects and groups. | |||
There was a problem hiding this comment.
Suggested change
| - **Search Services**: Resolve issues that caused items to be missing from Renku 2.0 search, including the in the search for adding members to projects and groups. | |
| - **Search Services**: Resolve issues that caused items to be missing from Renku 2.0 search, including in the search for adding members to projects and groups. |
There was a problem hiding this comment.
I cannot process the second part of the sentence; do we want to give examples of items that were missing or we want to say that search now includes projects and groups' members. If the first case, I'd write it as ..., including projects and groups' members and if the second case: ... including adding members to projects and groups in the search.
Panaetius
approved these changes
Oct 8, 2024
Panaetius
approved these changes
Oct 8, 2024
Panaetius
added a commit
that referenced
this pull request
Oct 10, 2024
* chore: create release 0.58.0 * fix: update more GitLab redirect URLs (#3780) * refactor: polish Renku 2.0 pages according to the latest design (#3786) * docs: fix changelog (#3789) * Update search services to 0.6.1 (#3790) * docs: Fix changelog (#3794) The "Individual Components" section was repeated during a merge. * chore: add rbac for new AmaltheaSessions CR * feat: update gateway to 1.1.0 Adds new credentials for new Amalthea version and removes obsolete Python code. * feat: update data service to 0.21.0 (#3796) Adds search reprovisioning. * feat: parametrize clusterRoles (#3785) Signed-off-by: Julien Godin <[email protected]> Co-authored-by: Julien Godin <[email protected]> Co-authored-by: Rok Roškar <[email protected]> Co-authored-by: Flora Thiebaut <[email protected]> * test: add dashboard v2 e2e tests (#3781) Co-authored-by: Renku Bot <[email protected]> Co-authored-by: Flora Thiebaut <[email protected]> * feat: renku v2 dashboard improvements (#3798) * feat: update data service to 0.22.0 feat: add support for filtering project and group listing by direct membership fix: allow unsetting storage secrets * feat: update renku-ui to 3.37.0 * docs: update changelog --------- Co-authored-by: Andrea Cordoba <[email protected]> Co-authored-by: Lorenzo <[email protected]> * update changelog (#3799) * bump notebooks version * fix: increase timeout for Authzed DB health probes (#3800) The timeout in k8s was increasesd in a recent PR. But this increases the timeout of the CLI we call in the Authzed DB image to actuall do the health checks. And since this CLI had a default timeout of 1s it was timing out even before the k8s timeout could take effect. We noticed that Authzed on renkulab.io was in a restart loop because of this. * fix: update renku-ui to 3.37.1 (#3801) Updates the UI to fix the HTTP 500 upon logging in with gateway 1.1.0. --------- Signed-off-by: Julien Godin <[email protected]> Co-authored-by: Flora Thiebaut <[email protected]> Co-authored-by: Lorenzo Cavazzi <[email protected]> Co-authored-by: eikek <[email protected]> Co-authored-by: Tasko Olevski <[email protected]> Co-authored-by: Julien Godin <[email protected]> Co-authored-by: Julien Godin <[email protected]> Co-authored-by: Rok Roškar <[email protected]> Co-authored-by: Flora Thiebaut <[email protected]> Co-authored-by: Andrea Cordoba <[email protected]> Co-authored-by: Andrea Cordoba <[email protected]> Co-authored-by: Lorenzo <[email protected]> Co-authored-by: Laura <[email protected]> Co-authored-by: Ralf Grubenmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.