Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add SSH into sessions docs #2947

Merged
merged 27 commits into from
Mar 1, 2023
Merged

docs: add SSH into sessions docs #2947

merged 27 commits into from
Mar 1, 2023

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius temporarily deployed to ci-renku-2947 February 13, 2023 14:44 — with GitHub Actions Inactive
@Panaetius Panaetius force-pushed the ssh-into-sessions-docs branch from 65ead1c to 8b7f6ba Compare February 14, 2023 13:19
@Panaetius Panaetius temporarily deployed to ci-renku-2947 February 14, 2023 13:19 — with GitHub Actions Inactive
@Panaetius Panaetius force-pushed the ssh-into-sessions-docs branch from 8b7f6ba to 63cab14 Compare February 14, 2023 13:36
@Panaetius Panaetius temporarily deployed to ci-renku-2947 February 14, 2023 13:36 — with GitHub Actions Inactive
@Panaetius Panaetius temporarily deployed to ci-renku-2947 February 20, 2023 11:13 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 20, 2023 12:32 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 20, 2023 12:55 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 20, 2023 12:56 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 20, 2023 13:09 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 20, 2023 13:43 — with GitHub Actions Inactive
@lokijuhy
Copy link
Member

@Panaetius I made some revisions, with the goal of providing scan-able list-based instructions over paragraph style text wherever possible.

lokijuhy
lokijuhy requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@lokijuhy lokijuhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted outstanding TODOs so we don't forget

docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
@lokijuhy @Panaetius
docs: formatting suggestion
e4710a0 
Co-authored-by: Ralf Grubenmann <[email protected]>
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 20, 2023 16:56 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 20, 2023 16:57 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to ci-renku-2947 February 24, 2023 16:19 — with GitHub Actions Inactive
@Panaetius Panaetius marked this pull request as ready for review February 27, 2023 08:19
@Panaetius Panaetius requested a review from a team as a code owner February 27, 2023 08:19
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 28, 2023 12:42 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to ci-renku-2947 February 28, 2023 12:49 — with GitHub Actions Inactive
@lorenzo-cavazzi
Copy link
Member

I updated the UI screenshots.
I still see the <Enter version number above sections; I guess we should update that before merging

@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 28, 2023 13:35 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 28, 2023 13:41 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 28, 2023 14:06 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 February 28, 2023 14:17 — with GitHub Actions Inactive
rokroskar
rokroskar requested changes Feb 28, 2023
View reviewed changes
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
docs/how-to-guides/renkulab/ssh-into-sessions.rst Outdated Show resolved Hide resolved
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 March 1, 2023 10:24 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 March 1, 2023 10:31 — with GitHub Actions Inactive
@lokijuhy lokijuhy temporarily deployed to ci-renku-2947 March 1, 2023 10:46 — with GitHub Actions Inactive
@lokijuhy lokijuhy deployed to ci-renku-2947 March 1, 2023 11:08 — with GitHub Actions Active
@lokijuhy lokijuhy merged commit 946e231 into feat/ssh-into-sessions Mar 1, 2023
@lokijuhy lokijuhy deleted the ssh-into-sessions-docs branch March 1, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokroskar rokroskar rokroskar requested changes

@lokijuhy lokijuhy lokijuhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Panaetius @lokijuhy @lorenzo-cavazzi @rokroskar