Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show commit messages in renkulab #852

Closed
ciyer opened this issue Mar 23, 2020 · 3 comments · Fixed by #917
Closed

Show commit messages in renkulab #852

ciyer opened this issue Mar 23, 2020 · 3 comments · Fixed by #917
Assignees

Comments

@ciyer
Copy link
Contributor

ciyer commented Mar 23, 2020

Motivation

Seeing the commit log is helpful to understand what has been happening in a project. I find myself often going to GitLab to see this, so we should integrate it into Renkulab directly.

Proposal

Add a tab "Commits" to the overview page and show the commit log there. They should be grouped by date -- there should be a header with the date and all commits in that date should be there. See mockup below.

Interactions

Initially,

  • It should be possible to diff a diff of the commit to its immediate parent
  • It should be possible to navigate to the commit in GitLab
  • Link to start environment at commit

Other interactions can be done later.

Context

image

Notes

  • There is already code to get commits in the Notebook component (Notebook.state.js probably). This should be moved up to a shared location.
  • May want to consider adding this a project submodel of the main redux store
@ciyer ciyer added this to the sprint-2020-03-02 milestone Mar 23, 2020
@rokroskar
Copy link
Member

Will this also then allow the user to select a commit to look at?

@ciyer ciyer changed the title Show commits messages in renkulab Show commit messages in renkulab Mar 24, 2020
@ciyer
Copy link
Contributor Author

ciyer commented Mar 24, 2020

Good point. Just clarified this in the issue desc.

@emmjab
Copy link
Contributor

emmjab commented Mar 26, 2020

Also along the lines of commits -- it would also be nice to see the first N chars of the commit message in the Environments tab when you're selecting a commit with which to start an environment! It would help users decide which commit to select and provide positive feedback for making descriptive commit messages

cc @vfried

@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Apr 15, 2020
lorenzo-cavazzi added a commit that referenced this issue Apr 24, 2020
Adds all the necessary logic to handle project's commits:
* Add a new tab in project overview to show commits
* Create ProjectCoordinator with basic metadata
* Create higher order function to easily map project data from global store to React components

fix #852
lorenzo-cavazzi added a commit that referenced this issue Apr 29, 2020
Adds all the necessary logic to handle project's commits:
* Add a new tab in project overview to show commits
* Create ProjectCoordinator with basic metadata
* Create higher order function to easily map project data from global store to React components

fix #852
lorenzo-cavazzi added a commit that referenced this issue Apr 29, 2020
Adds all the necessary logic to handle project's commits:
* Add a new tab in project overview to show commits
* Create ProjectCoordinator with basic metadata
* Create higher order function to easily map project data from global store to React components

fix #852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants