Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make doctor fix for workflow ids also update oid and derived_from #3723

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Apr 8, 2024

this PR also introduces a RENKU_LOCK_PATH env var that a user can set to put the renku lockfile somewhere else, intended to solve issues users see when their home dir is mounted on NFS.

@Panaetius Panaetius requested a review from a team as a code owner April 8, 2024 07:23
@coveralls
Copy link
Collaborator

coveralls commented Apr 8, 2024

Pull Request Test Coverage Report for Build 8596455794

Details

  • 12 of 21 (57.14%) changed or added relevant lines in 2 files are covered.
  • 37 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.9%) to 86.102%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/config.py 6 8 75.0%
renku/command/checks/workflow.py 6 13 46.15%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 82.83%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/core/init.py 1 92.86%
renku/ui/cli/init.py 1 96.95%
renku/core/util/os.py 2 88.38%
renku/core/dataset/context.py 3 91.43%
renku/core/dataset/dataset.py 3 85.34%
renku/core/util/git.py 5 85.32%
renku/ui/service/gateways/repository_cache.py 8 61.76%
renku/ui/cli/service.py 12 72.49%
Totals Coverage Status
Change from base Build 7812287413: 0.9%
Covered Lines: 26969
Relevant Lines: 31322

💛 - Coveralls

@Panaetius Panaetius merged commit 050ed61 into develop Apr 8, 2024
27 of 29 checks passed
@Panaetius Panaetius deleted the fix-doctor-fix branch April 8, 2024 14:08
Panaetius pushed a commit that referenced this pull request Apr 9, 2024
* fix: make doctor fix for workflow ids also update oid and derived_from (#3723)

* fix(cli): fix the doctor fix for plan ids to reassign oid's

* allow overriding renku lock path

* also fix derived from

* chore: release v2.9.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants