Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): don't fail on workflows without inputs/outputs and print approriate warnings #3694

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix(cli): don't fail on workflows without inputs/outputs and print approriate warnings #3694

merged 2 commits into from
Feb 5, 2024

Conversation

Panaetius
Copy link
Member

closes #3654

@Panaetius Panaetius requested a review from a team as a code owner January 23, 2024 13:47
@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7786040388

  • -3 of 8 (62.5%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 85.148%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/domain_model/workflow/plan.py 3 4 75.0%
renku/core/workflow/model/concrete_execution_graph.py 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/ui/cli/init.py 1 96.95%
renku/ui/cli/service.py 1 78.31%
Totals Coverage Status
Change from base Build 7785635789: -0.02%
Covered Lines: 26653
Relevant Lines: 31302
💛 - Coveralls

m-alisafaee
m-alisafaee approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Panaetius Panaetius enabled auto-merge (squash) February 5, 2024 14:30
@Panaetius Panaetius merged commit 33a29aa into develop Feb 5, 2024
27 checks passed
@Panaetius Panaetius deleted the fix/3654-workflow-file-no-inputs branch February 5, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

renku run workflowfile broken without inputs/outputs
3 participants
@Panaetius @coveralls @m-alisafaee