Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service): accept commit-sha in config.show #3685

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix(service): accept commit-sha in config.show #3685

merged 2 commits into from
Jan 17, 2024

Conversation

m-alisafaee
Copy link
Contributor

Fixes #3649

@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7541936082

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 85.459%
Totals Coverage Status
Change from base Build 7541920372: -0.005%
Covered Lines: 26435
Relevant Lines: 30933
💛 - Coveralls

@m-alisafaee m-alisafaee marked this pull request as ready for review January 16, 2024 01:07
@m-alisafaee m-alisafaee requested a review from a team as a code owner January 16, 2024 01:07
@m-alisafaee m-alisafaee merged commit 00da768 into develop Jan 17, 2024
29 checks passed
@m-alisafaee m-alisafaee deleted the 3649-config-show-reference branch January 17, 2024 08:32
Panaetius pushed a commit that referenced this pull request Jan 17, 2024
@github-actions
chore: release v2.9.0 (#3686)
af89ce6 
* fix(service): accept commit-sha in config.show (#3685)

* feat: add cloud storage support for session start (#3629)

* chore: release v2.9.0

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing commit references to config.show doesn't work as expected
3 participants
@m-alisafaee @coveralls @Panaetius