Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): do not error unneccesarily on session stop #3642

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

Panaetius
Copy link
Member

Fixes #3589

@Panaetius Panaetius requested a review from a team as a code owner October 16, 2023 13:23
@coveralls
Copy link
Collaborator

coveralls commented Oct 16, 2023

Pull Request Test Coverage Report for Build 6822655139

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 82.825%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/session/session.py 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 28.57%
Totals Coverage Status
Change from base Build 6822651972: -0.02%
Covered Lines: 25453
Relevant Lines: 30731

💛 - Coveralls

@Panaetius Panaetius enabled auto-merge (squash) November 10, 2023 08:54
@Panaetius Panaetius merged commit 4726f66 into develop Nov 10, 2023
22 of 25 checks passed
@Panaetius Panaetius deleted the fix/3589-stop-all-sessions branch November 10, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

renku session stop errors out but it stops all sessions
3 participants