Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): do not start a session when in detached HEAD state #3636

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix(cli): do not start a session when in detached HEAD state #3636

merged 2 commits into from
Oct 11, 2023

Conversation

m-alisafaee
Copy link
Contributor

Description

Don't start a session if the repository is in detached HEAD state.

Fixes #3619

@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6479334815

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 85.511%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/core/workflow/activity.py 1 93.93%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 74.07%
Totals Coverage Status
Change from base Build 6475078373: 0.04%
Covered Lines: 26280
Relevant Lines: 30733
💛 - Coveralls

@m-alisafaee m-alisafaee marked this pull request as ready for review October 11, 2023 06:16
@m-alisafaee m-alisafaee requested a review from a team as a code owner October 11, 2023 06:16
@m-alisafaee m-alisafaee enabled auto-merge (squash) October 11, 2023 07:28
@m-alisafaee m-alisafaee merged commit 80f70f5 into develop Oct 11, 2023
26 checks passed
@m-alisafaee m-alisafaee deleted the 3619-session-start-bug branch October 11, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: renku session start -p renkulab --ssh
3 participants
@m-alisafaee @coveralls @Panaetius