Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): do not clone submodules in renku clone command #3630

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix(core): do not clone submodules in renku clone command #3630

merged 2 commits into from
Oct 4, 2023

Conversation

m-alisafaee
Copy link
Contributor

Fixes #3581

@coveralls
Copy link
Collaborator

coveralls commented Oct 1, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6398054001

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 86.943%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/util/git.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 88.86%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 74.07%
Totals Coverage Status
Change from base Build 6377776799: 0.1%
Covered Lines: 26255
Relevant Lines: 30198
💛 - Coveralls

@m-alisafaee m-alisafaee marked this pull request as ready for review October 2, 2023 08:21
@m-alisafaee m-alisafaee requested a review from a team as a code owner October 2, 2023 08:21
@m-alisafaee m-alisafaee merged commit e9986e0 into develop Oct 4, 2023
27 of 28 checks passed
@m-alisafaee m-alisafaee deleted the 3581-git-clone-fix branch October 4, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git clone should not try to clone submodules and surface errors properly
3 participants
@m-alisafaee @coveralls @Panaetius