-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make usage of name and slug consistent #3620
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
force-pushed
the
3563-consistent-name-slug
branch
from
September 18, 2023 19:42
725d9da
to
c2e3395
Compare
m-alisafaee
force-pushed
the
3563-consistent-name-slug
branch
2 times, most recently
from
September 19, 2023 06:35
bb0cd4a
to
9660fbb
Compare
m-alisafaee
force-pushed
the
3563-consistent-name-slug
branch
5 times, most recently
from
September 21, 2023 07:32
5af000a
to
61515aa
Compare
Panaetius
requested changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
One question, do we need to bump the minimum renku version? I assume old CLi won't be able to work on a project written to by this version?
m-alisafaee
force-pushed
the
3563-consistent-name-slug
branch
from
October 3, 2023 20:23
9a9a875
to
54823f7
Compare
m-alisafaee
force-pushed
the
3563-consistent-name-slug
branch
from
October 3, 2023 20:34
54823f7
to
077ee8c
Compare
m-alisafaee
force-pushed
the
3563-consistent-name-slug
branch
4 times, most recently
from
October 4, 2023 15:36
b940643
to
85acdac
Compare
m-alisafaee
force-pushed
the
3563-consistent-name-slug
branch
3 times, most recently
from
October 5, 2023 04:26
49d2c1b
to
fc7c56b
Compare
m-alisafaee
force-pushed
the
3563-consistent-name-slug
branch
from
October 10, 2023 00:23
fc7c56b
to
e2319e3
Compare
Panaetius
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
name
/title
withslug
/name
in datasets. Related command flags are hidden and deprecation warning is printed upon their usage (e.g.--name
/--short-name
when importing a dataset).Fixes: #3563