Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make usage of name and slug consistent #3620

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

m-alisafaee
Copy link
Contributor

@m-alisafaee m-alisafaee commented Sep 18, 2023

Description

Replaces name/title with slug/name in datasets. Related command flags are hidden and deprecation warning is printed upon their usage (e.g. --name/--short-name when importing a dataset).

Fixes: #3563

@coveralls
Copy link
Collaborator

coveralls commented Sep 18, 2023

Pull Request Test Coverage Report for Build 6463087983

  • 511 of 589 (86.76%) changed or added relevant lines in 55 files are covered.
  • 8 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 85.796%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/dataset/datasets_provenance.py 9 10 90.0%
renku/infrastructure/database.py 5 6 83.33%
renku/command/checks/validate_shacl.py 0 2 0.0%
renku/command/format/dataset_files.py 2 4 50.0%
renku/core/dataset/providers/renku.py 15 18 83.33%
renku/command/checks/datasets.py 4 9 44.44%
renku/domain_model/dataset.py 36 41 87.8%
renku/ui/service/views/v1/datasets.py 68 76 89.47%
renku/ui/service/serializers/v1/datasets.py 79 93 84.95%
renku/core/dataset/dataset.py 52 67 77.61%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/core/dataset/providers/renku.py 1 79.86%
renku/core/interface/dataset_gateway.py 1 59.09%
renku/core/workflow/activity.py 1 93.93%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 74.07%
renku/command/rollback.py 2 78.7%
Totals Coverage Status
Change from base Build 6408273758: 0.02%
Covered Lines: 26240
Relevant Lines: 30584

💛 - Coveralls

@m-alisafaee m-alisafaee force-pushed the 3563-consistent-name-slug branch 2 times, most recently from bb0cd4a to 9660fbb Compare September 19, 2023 06:35
@m-alisafaee m-alisafaee reopened this Sep 19, 2023
@m-alisafaee m-alisafaee force-pushed the 3563-consistent-name-slug branch 5 times, most recently from 5af000a to 61515aa Compare September 21, 2023 07:32
@m-alisafaee m-alisafaee marked this pull request as ready for review September 21, 2023 08:11
@m-alisafaee m-alisafaee requested a review from a team as a code owner September 21, 2023 08:11
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

One question, do we need to bump the minimum renku version? I assume old CLi won't be able to work on a project written to by this version?

renku/ui/cli/dataset.py Outdated Show resolved Hide resolved
@m-alisafaee m-alisafaee force-pushed the 3563-consistent-name-slug branch from 9a9a875 to 54823f7 Compare October 3, 2023 20:23
@m-alisafaee m-alisafaee marked this pull request as draft October 3, 2023 20:32
@m-alisafaee m-alisafaee closed this Oct 3, 2023
@m-alisafaee m-alisafaee reopened this Oct 3, 2023
@m-alisafaee m-alisafaee force-pushed the 3563-consistent-name-slug branch from 54823f7 to 077ee8c Compare October 3, 2023 20:34
@m-alisafaee m-alisafaee closed this Oct 3, 2023
@m-alisafaee m-alisafaee reopened this Oct 3, 2023
@m-alisafaee m-alisafaee force-pushed the 3563-consistent-name-slug branch 4 times, most recently from b940643 to 85acdac Compare October 4, 2023 15:36
@m-alisafaee m-alisafaee force-pushed the 3563-consistent-name-slug branch 3 times, most recently from 49d2c1b to fc7c56b Compare October 5, 2023 04:26
@m-alisafaee m-alisafaee force-pushed the 3563-consistent-name-slug branch from fc7c56b to e2319e3 Compare October 10, 2023 00:23
@m-alisafaee m-alisafaee marked this pull request as ready for review October 10, 2023 07:27
@m-alisafaee m-alisafaee requested a review from Panaetius October 10, 2023 08:07
@m-alisafaee m-alisafaee merged commit b31ade0 into develop Oct 10, 2023
28 checks passed
@m-alisafaee m-alisafaee deleted the 3563-consistent-name-slug branch October 10, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

make name and slug consistent for datasets and projects
3 participants