Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): skip fast cache migrations check for anonymous users #3577

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

Panaetius
Copy link
Member

We can't do the gitlab api path for users that aren't logged in, since we don't have a gitlab token for those.

@Panaetius Panaetius requested a review from a team as a code owner August 4, 2023 09:34
@coveralls
Copy link
Collaborator

coveralls commented Aug 4, 2023

Pull Request Test Coverage Report for Build 5822346792

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 400 unchanged lines in 39 files lost coverage.
  • Overall coverage increased (+0.9%) to 85.7%

Files with Coverage Reduction New Missed Lines %
renku/command/schema/dataset.py 1 92.37%
renku/core/dataset/providers/api.py 1 83.26%
renku/core/dataset/providers/common.py 1 94.44%
renku/core/dataset/providers/repository.py 1 88.46%
renku/core/dataset/providers/s3.py 1 96.25%
renku/core/dataset/providers/web.py 1 89.91%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/core/migration/models/v3.py 1 97.24%
renku/core/storage.py 1 79.79%
renku/core/util/os.py 1 88.89%
Totals Coverage Status
Change from base Build 5819037706: 0.9%
Covered Lines: 25817
Relevant Lines: 30125

💛 - Coveralls

@Panaetius Panaetius enabled auto-merge (squash) August 10, 2023 14:22
@Panaetius Panaetius merged commit 9ee3176 into develop Aug 10, 2023
@Panaetius Panaetius deleted the fix-cache-fast-op branch August 10, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants