Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix bad venv setup #162

Merged
merged 1 commit into from
Feb 1, 2023
Merged

chore: fix bad venv setup #162

merged 1 commit into from
Feb 1, 2023

Conversation

rokroskar
Copy link
Member

@rokroskar rokroskar commented Feb 1, 2023

The line

COPY --from builder ${HOME}/.renku/venv ${HOME}/.renku/venv

does not replace the contents but simply adds to it, leading to a bad state of the packages in the virtualenv. This PR fixes this by brute force - removing the directory beforehand. A symptom of this was the renku CLI complaining about a bad version of the cwltool, e.g.

You are using cwltool version 3.1.20211107152837, which might not be compatible with version 3.1.20220628170238 used by Toil. You should consider running 'pip install cwltool==3.1.20220628170238' to match Toil's cwltool version.

In a project created with this template, no such warning/error is generated:

image

Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any specific reason for not using a separate RUN command?

@rokroskar
Copy link
Member Author

Generally it's considered good practice to combine them unless they have to be separated.

@rokroskar rokroskar merged commit 7d6bbfe into master Feb 1, 2023
@rokroskar rokroskar deleted the 000-fix-dockerfile branch February 1, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants