feat: multi-stage builds #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olevski
requested changes
Jan 26, 2023
|
@olevski I did check them in the session - you can try any of the projects I linked at the top. |
olevski
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update changes the Dockerfile in the template to use multi-stage builds for the renku CLI installation and the user-defined libraries. By separating out the two stages, we make sure that changes to one do not trigger a (costly) rebuild in the other. The change requires that we set the
DOCKER_BUILDKITflag, which improves efficiency by building the stages in parallel.Here are the test projects:
https://dev.renku.ch/projects/rokroskar/test-new-python-template-2
https://dev.renku.ch/projects/rokroskar/test-new-r-template-2
https://dev.renku.ch/projects/rokroskar/test-new-julia-template
https://dev.renku.ch/projects/rokroskar/test-new-bioc-template