fix: use virtualenv instead of pipx for renku-python #128
Conversation
R-minimal/Dockerfile
Outdated
| source .renku-python/bin/activate ; \ | ||
| version_string=$(pip show renku | grep Version) ; \ | ||
| pattern='Version: (.*)$' ; \ | ||
| [[ $version_string =~ $pattern ]] ; \ | ||
| currentversion=${BASH_REMATCH[1]} ; \ |
There was a problem hiding this comment.
what's wrong with renku --version?
There was a problem hiding this comment.
Can't you see the beauty in that regex...? 🤦
fair point
There was a problem hiding this comment.
well maybe @Panaetius had some reason to not use it in the first place either...
There was a problem hiding this comment.
maybe it simply predates the introduction of renku --version?
There was a problem hiding this comment.
Do you know what renku --version returns for non-released versions? I guess @Panaetius will tell us :)
There was a problem hiding this comment.
something like this: 0.16.1.dev16+g78fad896 - see the long regex at the bottom of the Dockerfile...
There was a problem hiding this comment.
indeed, renku --version and the version displayed by pip show or pipx list seem to be identical also dev versions. I don't see a reason for not using renku --version then.
ableuler
force-pushed
the
000-pin-setuptools
branch
from
9119004 to
63ac7fa
Compare
ableuler
force-pushed
the
000-pin-setuptools
branch
from
63ac7fa to
df12bef
Compare
Depends on SwissDataScienceCenter/renkulab-docker#187 being released.Ready to merge.