-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new template for batch execution #123
Conversation
The content and location of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for putting this together! a few minor comments
@@ -0,0 +1,46 @@ | |||
# For finding latest versions of the base image see | |||
# https://github.com/SwissDataScienceCenter/renkulab-docker | |||
ARG RENKU_BASE_IMAGE=renku/renkulab-batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll probably want to point to a specific tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. probably 0.8.x in the next releases of renku-docker
@@ -0,0 +1,39 @@ | |||
# {{ name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to mention in the readme something about the batch dockerfile and what the intent here is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. absolutely.
@@ -0,0 +1,52 @@ | |||
#!/bin/bash -l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file to be used by the renku CLI command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, yes. but i am still not sure what would be the best for this script-template. content, location, etc. some decisions to be made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's an internal file that the user shouldn't really need to look at/change, it could go in a subdirectory of .renku
e.g. .renku/templates/
?
@@ -18,6 +18,11 @@ | |||
description: The simplest Julia 1.6.1-based renku project with a basic directory structure and necessary supporting files. | |||
variables: | |||
description: short description added at the beginning of the readme file | |||
- folder: batch-minimal | |||
name: Batch Version of Basic Python (3.8) Project | |||
description: The simplest Python-3.8-based renku project for batch execution with a basic directory structure and necessary supporting files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just build on the base python template and reword this with something like
Identical to the basic Python project, but also provides images and templates for running renku workflows on batch systems.
@TaoSunVoyage is this closed to being merged? I think we're going to tag a new release here soon. |
@ableuler not yet. We are waiting for the new workflow executor |
I'm not sure we need a separate template for batch execution. I rather envision a situation where a "batch" dockerfile (and associated configuration) is added to a normal project. Closing this for now, we may revisit at some later point. |
Add template for batch execution #118
Main difference between python-minimal template:
environment.yml
, python dependencies have to be installed by pipDockerfile.batch
for batch version image, and a new job in.gitlab-ci.yml
sbatch-script-template.sh
template for sbatch script