Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new template for batch execution #123

Closed
wants to merge 5 commits into from

Conversation

TaoSunVoyage
Copy link

@TaoSunVoyage TaoSunVoyage commented Jul 22, 2021

Add template for batch execution #118

Main difference between python-minimal template:

  • no environment.yml, python dependencies have to be installed by pip
  • Dockerfile.batch for batch version image, and a new job in .gitlab-ci.yml
  • sbatch-script-template.sh template for sbatch script

@TaoSunVoyage TaoSunVoyage changed the title feat: new template for feat: new template for batch execution Jul 22, 2021
@TaoSunVoyage TaoSunVoyage linked an issue Jul 22, 2021 that may be closed by this pull request
@TaoSunVoyage
Copy link
Author

The content and location of sbatch-script-template.sh is still open for discussion.

@TaoSunVoyage TaoSunVoyage requested a review from rokroskar July 22, 2021 15:47
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for putting this together! a few minor comments

@@ -0,0 +1,46 @@
# For finding latest versions of the base image see
# https://github.com/SwissDataScienceCenter/renkulab-docker
ARG RENKU_BASE_IMAGE=renku/renkulab-batch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll probably want to point to a specific tag

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. probably 0.8.x in the next releases of renku-docker

@@ -0,0 +1,39 @@
# {{ name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to mention in the readme something about the batch dockerfile and what the intent here is?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. absolutely.

@@ -0,0 +1,52 @@
#!/bin/bash -l
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file to be used by the renku CLI command?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, yes. but i am still not sure what would be the best for this script-template. content, location, etc. some decisions to be made.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's an internal file that the user shouldn't really need to look at/change, it could go in a subdirectory of .renku e.g. .renku/templates/?

@@ -18,6 +18,11 @@
description: The simplest Julia 1.6.1-based renku project with a basic directory structure and necessary supporting files.
variables:
description: short description added at the beginning of the readme file
- folder: batch-minimal
name: Batch Version of Basic Python (3.8) Project
description: The simplest Python-3.8-based renku project for batch execution with a basic directory structure and necessary supporting files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just build on the base python template and reword this with something like

Identical to the basic Python project, but also provides images and templates for running renku workflows on batch systems.

@ableuler
Copy link
Contributor

ableuler commented Sep 9, 2021

@TaoSunVoyage is this closed to being merged? I think we're going to tag a new release here soon.

@TaoSunVoyage TaoSunVoyage marked this pull request as draft September 9, 2021 21:46
@TaoSunVoyage
Copy link
Author

@ableuler not yet. We are waiting for the new workflow executor toil.

@rokroskar
Copy link
Member

I'm not sure we need a separate template for batch execution. I rather envision a situation where a "batch" dockerfile (and associated configuration) is added to a normal project. Closing this for now, we may revisit at some later point.

@rokroskar rokroskar closed this Dec 23, 2022
@rokroskar rokroskar deleted the 118-batch-template branch December 23, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New template for batch execution
3 participants