use user credentials for pulling images #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ableuler
suggested changes
Jun 8, 2020
rokroskar
force-pushed
the
105-user-credentials
branch
from
2ffd403 to
2aaed8e
Compare
rokroskar
force-pushed
the
105-user-credentials
branch
from
2aaed8e to
6e6e9f8
Compare
Did this on rok2.dev.renku.ch - seems to work |
ableuler
approved these changes
Jun 10, 2020
|
Cool - let's merge this! Do you create an issue for the cleanup part? |
|
follow-up: #333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does away with the need for admin access to the gitlab instance that backs the renku deployment by using the oauth2 token of the user launching the environment to authenticate with the image registry.
closes #105
this is running currently on rok2.dev.renku.ch.