Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding new relation for listing private-only entities #611

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

eikek
Copy link
Member

@eikek eikek commented Jan 17, 2025

/deploy

@eikek eikek force-pushed the private-resource-permission branch from 844a52f to 84a13da Compare January 21, 2025 08:27
@coveralls
Copy link

coveralls commented Jan 21, 2025

Pull Request Test Coverage Report for Build 12909527345

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 86.541%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/error_handler.py 1 89.47%
Totals Coverage Status
Change from base Build 12884705401: 0.02%
Covered Lines: 15394
Relevant Lines: 17788

💛 - Coveralls

@eikek eikek force-pushed the private-resource-permission branch 4 times, most recently from 89b92c0 to 07bed78 Compare January 22, 2025 12:00
@eikek eikek force-pushed the private-resource-permission branch from 07bed78 to 84281e5 Compare January 22, 2025 13:43
@eikek eikek marked this pull request as ready for review January 22, 2025 13:44
@eikek eikek requested a review from a team as a code owner January 22, 2025 13:44
@eikek eikek changed the title Private resource permission feat: Adding new relation for listing private-only entities Jan 22, 2025
@eikek eikek temporarily deployed to renku-ci-ds-611 January 22, 2025 14:01 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-611.dev.renku.ch

@leafty
Copy link
Member

leafty commented Jan 22, 2025

Non-blocking: should this be merged into a feature branch instead? As is, the authorization changes are not used anywhere in code. If these changes are part of a larger set of changes, it is easier for everyone contributing to the repository if a feature branch is used.

@olevski
Copy link
Member

olevski commented Jan 22, 2025

Yeah lets merge this into a feature branch. That way if we have to modify the schema before an official release we wont have to do migrations.

@eikek eikek changed the base branch from main to feature/search-migration January 22, 2025 15:06
@eikek eikek merged commit 99ff4e9 into feature/search-migration Jan 22, 2025
37 of 38 checks passed
@eikek eikek deleted the private-resource-permission branch January 22, 2025 15:42
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants