-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add vendor for polybox storage #604
fix: add vendor for polybox storage #604
Conversation
You can access the deployment of this PR at https://renku-ci-ds-604.dev.renku.ch |
Pull Request Test Coverage Report for Build 12851284222Details
💛 - Coveralls |
This is currently blocked by the UI and how it interprets fields in the rclone config and which of these fields are sent to the backend when a data connector is created. Besically it seems that there is no way to have a field in the rclone config that has a default and is also sent to the backend when a cloud storage is created. If we want the ui to send the field to the backend then the field should be set to required without a default value. @lorenzo-cavazzi correctly if I am wrong here. But this is my understanding from our quick discussion. EDIT: I figured it out. We set the vendor now whenever we create the config for the rclone csi pvc when we launch a session. And this is only for next cloud and switch drive. |
c90f744
to
e684d3f
Compare
e684d3f
to
ea60502
Compare
55ab8fe
to
44dd94d
Compare
@olevski I think you may want to deploy against |
components/renku_data_services/notebooks/api/schemas/cloud_storage.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix seems to work for polybox storage 👍 👏
…/cloud_storage.py Co-authored-by: Flora Thiebaut <[email protected]>
Tearing down the temporary RenkuLab deplyoment for this PR. |
This is meant to fix the issue here: https://www.notion.so/renku/Prevent-File-changed-pop-ups-for-Polybox-folders-1730df2efafc80948abee9f248cbef9b?pvs=4
It is a popup that shows up every time you mount a polybox storage and you edit a file:
There may be a few other options we can cleanup in the csi-rclone code. But this one is the main one that is causing the issue.
/deploy renku=release-0.64.0