Feat/shipwright strategies #601
Conversation
This command replaces the bash scrip that triggers the various lifecycle steps done by kpack so that it can be used with Shipwright.
Now the output of the various commands used are forwarded to the helper output so there's better information available to the user.
It can still be triggered using the script.
This simplifies starting the development environment.
The lifecycle repository provides the creator binary which runs each step of the build lifecycle in a similar fashion as what the original script did as well as its go counterpart. This commit thus removes all of that and updates the manifest to use creator. Python tests have been added to ensure that the buildrun is successfull.
sgaist
force-pushed
the
feat/shipwright-strategies
branch
from
78cfdc2 to
83cd71d
Compare
There was a problem hiding this comment.
A general question. I am only looking at a diff of this PR. But is the idea that the kubectl CLI will be called in production?
Also it is better to use a BuildStrategy rather than a ClusterBuildStrategy. Since the cluster one is cluster scoped and not namespaced. IMO it is better to have it namespaced - i.e. safer and it requries less permissions in the cluster.
It's not needed anymore.
AFAIK, no. I wrote the test to confirm that things are working as intended with the current state of development.
Agreed, I'll push a new version using a |
ClusterBuildStrategy is too broad for the use of Renku. Make use of BuildStrategy and update tests to use a namespace.
Describe your changes
This PR implements the Shipwright CRDs to use paketo buildpacks to build the final image.
It uses the creator tool from the buildpack's lifecycle.
There's a test validating the build and use of the strategy.
The full builder is currently used so that the strategy can cover a larger set of projects.