Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update project ETag when the namespace slug is changed #596

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: update project ETag when the namespace slug is changed #596

wants to merge 2 commits into from

Conversation

leafty
Copy link
Member

@leafty leafty commented Jan 6, 2025

WIP

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12634611490

Details

  • 22 of 23 (95.65%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 86.845%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/project/models.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/error_handler.py 1 89.47%
components/renku_data_services/notebooks/api/classes/k8s_client.py 7 63.58%
Totals Coverage Status
Change from base Build 12464122126: -0.003%
Covered Lines: 15223
Relevant Lines: 17529
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leafty @coveralls