-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: merge UserInfo and UserWithNamespace #362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack: Change managed by git-spice. |
Panaetius
force-pushed
the
refactor-merge-userinfo-and
branch
6 times, most recently
from
August 26, 2024 09:55
2092f88
to
ba299ba
Compare
Pull Request Test Coverage Report for Build 10881005641Details
💛 - Coveralls |
Panaetius
force-pushed
the
refactor-merge-userinfo-and
branch
from
September 12, 2024 13:11
fb26d44
to
0627601
Compare
olevski
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this Ralf. Just one minor change.
Panaetius
force-pushed
the
refactor-merge-userinfo-and
branch
from
September 16, 2024 09:22
cafff7d
to
0a45082
Compare
olevski
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines UserInfo and UserWithNamespace classes into a single user object that always has to have a namespace (as there are no users without a namespace.