Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge UserInfo and UserWithNamespace #362

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Aug 21, 2024

Combines UserInfo and UserWithNamespace classes into a single user object that always has to have a namespace (as there are no users without a namespace.

@Panaetius
Copy link
Member Author

Panaetius commented Aug 21, 2024

This change is part of the following stack:

Change managed by git-spice.

@Panaetius Panaetius force-pushed the refactor-merge-userinfo-and branch 6 times, most recently from 2092f88 to ba299ba Compare August 26, 2024 09:55
@coveralls
Copy link

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10881005641

Details

  • 88 of 112 (78.57%) changed or added relevant lines in 11 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 90.444%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/authz/authz.py 2 3 66.67%
components/renku_data_services/message_queue/converters.py 7 8 87.5%
components/renku_data_services/namespace/orm.py 7 13 53.85%
components/renku_data_services/base_models/core.py 8 15 53.33%
components/renku_data_services/namespace/db.py 19 28 67.86%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_models/core.py 1 85.85%
components/renku_data_services/project/blueprints.py 1 96.67%
components/renku_data_services/storage/blueprints.py 1 94.76%
components/renku_data_services/namespace/db.py 3 85.88%
Totals Coverage Status
Change from base Build 10878688602: -0.1%
Covered Lines: 9332
Relevant Lines: 10318

💛 - Coveralls

@Panaetius Panaetius marked this pull request as ready for review August 26, 2024 12:55
@Panaetius Panaetius requested a review from a team as a code owner August 26, 2024 12:55
@Panaetius Panaetius force-pushed the refactor-merge-userinfo-and branch from fb26d44 to 0627601 Compare September 12, 2024 13:11
@Panaetius Panaetius requested a review from olevski September 12, 2024 13:11
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Ralf. Just one minor change.

components/renku_data_services/users/db.py Outdated Show resolved Hide resolved
components/renku_data_services/users/db.py Outdated Show resolved Hide resolved
@Panaetius Panaetius requested a review from olevski September 16, 2024 09:17
@Panaetius Panaetius force-pushed the refactor-merge-userinfo-and branch from cafff7d to 0a45082 Compare September 16, 2024 09:22
@Panaetius Panaetius merged commit 4c89c4b into main Sep 16, 2024
14 checks passed
@Panaetius Panaetius deleted the refactor-merge-userinfo-and branch September 16, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants