Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscode frontend feature for new amalthea #18

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olevski
Copy link
Member

@olevski olevski commented Nov 13, 2024

@rokroskar this is how we can use features to inject frontends into our sessions.

I am pretty sure this will work. I am not sure how to test this without fully publishing the feature though.

Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@@ -0,0 +1,15 @@

# Renku CLI (renku)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be changed


# Renku CLI (renku)

Installs vscode for running in Renku.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Installs vscode for running in Renku.
Installs VSCode for running in Renku.

@rokroskar
Copy link
Member

You can build an image locally by putting the content of this feature into a local .devcontainer directory and using the relative path in your devcontainer.json

@olevski
Copy link
Member Author

olevski commented Nov 13, 2024

Ah the problem is that the entrypoint field in the devcontainer feature spec does not get used in the image. I thought it will just override the entrypoint of the image that was built but it does not. It only gets executed when you start things with the devcontainer cli.

@olevski olevski marked this pull request as draft November 14, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants