mmoda/smartsky templates (with icons!) #16

volodymyrss · 2022-09-07T15:06:57Z

In our common SmartSky SDSC project, we could really benefit from some adapted templates. I checked that they work as a custom source.

add kg vis plugin
add astroquery plugin

rokroskar

Apologies this went unchecked for so long! I didn't see it until just now. Not sure if it's still relevant, but I made a few suggestions for improvements

rokroskar · 2023-07-03T14:53:29Z

python-heasoft-osa/Dockerfile

+
+USER oda
+
+ENTRYPOINT bash -c 'export HOME_OVERRRIDE=/tmp/jovyan; mkdir $HOME_OVERRRIDE; cd /tmp/jovyan; source /init.sh; jupyter lab --ip 0.0.0.0 --no-browser'


It's better to follow the entrypoint pattern from the base Renku templates: https://github.com/SwissDataScienceCenter/renkulab-docker/blob/main/docker/py/Dockerfile#L99 and https://github.com/SwissDataScienceCenter/renkulab-docker/blob/main/docker/py/entrypoint.sh

I updated the Dockerfile using the approach you suggested

I updated the Dockerfile using the approach you suggested

@burnout87 please check the image, it does not work for me.

mmoda/Dockerfile

python-heasoft-osa/Dockerfile

Co-authored-by: Rok Roškar <[email protected]>

…project-templates into main

rokroskar · 2023-10-05T12:27:41Z

@volodymyrss should this be reviewed again?

volodymyrss · 2023-10-05T12:56:52Z

@volodymyrss should this be reviewed again?

Thanks for the ping, let us just revise it with the latest plugin versions. @burnout87 could you please help?

In relation to oda-hub/hugo-odahub#70

rokroskar · 2023-10-05T14:00:24Z

ok thanks! When you're done please re-request the review.

burnout87 · 2023-10-10T15:05:23Z

I added the two plugins in the requirements, in addition to some brief README inputs.

I also tried to implement the suggested changes for the Dockerfile of the mmoda template.

burnout87 · 2023-11-22T13:40:27Z

I cannot request for review, but I applied the two suggested changes @rokroskar

python-heasoft-osa/entrypoint.sh

burnout87 · 2023-11-22T13:59:45Z

One last question: I added the two plugins (renku-graph-vis and renku-aqs-annotation) inside the requirements.txt, would it make more sense to have those listed within the environment.yml?

rokroskar · 2023-11-28T13:18:18Z

One last question: I added the two plugins (renku-graph-vis and renku-aqs-annotation) inside the requirements.txt, would it make more sense to have those listed within the environment.yml?

I think that's up to you. From the POV of the image build it's the same.

burnout87 · 2023-11-29T10:30:58Z

One last question: I added the two plugins (renku-graph-vis and renku-aqs-annotation) inside the requirements.txt, would it make more sense to have those listed within the environment.yml?

I think that's up to you. From the POV of the image build it's the same.

thanks, I think it's ready for review now

burnout87 · 2023-12-18T10:16:37Z

Did you manage to take a look at this @rokroskar ?

manifest.yaml

mmoda/README.md

python-heasoft-osa/Dockerfile

rokroskar · 2023-12-18T15:52:13Z

python-heasoft-osa/entrypoint.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+
+export HOME_OVERRRIDE=/tmp/jovyan; 


this is different than what is set in the Dockerfile

We need a writable directory, it differs. Anyway, I removed the during the build.
Maybe home will work too, we'll try.

rokroskar · 2023-12-18T15:53:38Z

python-heasoft-osa/Dockerfile

+# https://github.com/SwissDataScienceCenter/renkulab-docker
+#ARG RENKU_BASE_IMAGE=renku/renkulab-py:3.7-0.7.3
+#FROM ${RENKU_BASE_IMAGE}
+FROM integralsw/osa-python:11.1-16-g88c002b7-20210507-170349-refcat-43.0-heasoft-6.29-python-3.8.2


is there some semver-compatible version of this tag? If yes, then we can have dependabot update the images automatically when new ones get released

Co-authored-by: Rok Roškar <[email protected]>

…ct-templates into mmoda-smartsky

volodymyrss changed the title ~~initial mmoda/smartsky~~ mmoda/smartsky templates (with icons!) Sep 7, 2022

volodymyrss mentioned this pull request Sep 7, 2022

some templates for SmartSky/MMODA project SwissDataScienceCenter/renku-project-template#147

Closed

initial mmoda/smartsky and heasoft

2439cf7

volodymyrss force-pushed the mmoda-smartsky branch from 7a0a009 to 2439cf7 Compare September 7, 2022 15:45

rokroskar requested changes Jul 3, 2023

View reviewed changes

volodymyrss and others added 5 commits July 27, 2023 17:05

Update python-heasoft-osa/Dockerfile

7c34c3b

Co-authored-by: Rok Roškar <[email protected]>

Merge branch 'main' into mmoda-smartsky

db6e222

Merge branch 'main' of github.com:SwissDataScienceCenter/contributed-…

9c8c0db

…project-templates into main

restore mmoda and heasoft

0bc06c9

restore mmoda and heasoft

d52aa65

This was referenced Aug 23, 2023

remove defaults channeld from environment.yml oda-hub/contributed-project-templates#3

Merged

add contrib templates of mmoda oda-hub/hugo-odahub#65

Open

burnout87 added 3 commits October 10, 2023 16:39

plugins included in the template

c88551a

some readme

e88ac52

more readme

d4a7543

mmoda Dockerfile template

aef49a7

burnout87 mentioned this pull request Nov 21, 2023

dissemination smartsky plugins renku oda-hub/hugo-odahub#70

Open

13 tasks

burnout87 added 3 commits November 22, 2023 11:55

added entrypoint script

75679b1

adapted to most recent renku dockerfile template

12a8861

most recent renku version

d3715ba

rokroskar reviewed Nov 22, 2023

View reviewed changes

python-heasoft-osa/entrypoint.sh Outdated Show resolved Hide resolved

rokroskar self-requested a review November 22, 2023 13:52

burnout87 added 2 commits November 22, 2023 15:07

run entrypont using passed args

f742d41

set DOCKER_BUILDKIT: 1

c74b467

burnout87 added 2 commits November 22, 2023 16:19

passingle jupyter command as args for the entrypoint

340297c

overriding jupyter command

0e238ac

numpy dependency mmoda template

8a0f80f

rokroskar requested changes Dec 18, 2023

View reviewed changes

burnout87 and others added 5 commits December 18, 2023 17:09

README comments

7681342

Update mmoda/README.md

98f3007

Co-authored-by: Rok Roškar <[email protected]>

Merge branch 'mmoda-smartsky' of github.com:oda-hub/contributed-proje…

7a73ce5

…ct-templates into mmoda-smartsky

reverting change manifest

8a13911

Update python-heasoft-osa/Dockerfile

69a5694

volodymyrss marked this pull request as ready for review December 20, 2023 13:19

Update python-heasoft-osa/Dockerfile

07eb234

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mmoda/smartsky templates (with icons!) #16

mmoda/smartsky templates (with icons!) #16

volodymyrss commented Sep 7, 2022 •

edited

Loading

rokroskar left a comment

rokroskar Jul 3, 2023

burnout87 Nov 22, 2023

volodymyrss Dec 20, 2023

rokroskar commented Oct 5, 2023

volodymyrss commented Oct 5, 2023

rokroskar commented Oct 5, 2023

burnout87 commented Oct 10, 2023 •

edited

Loading

burnout87 commented Nov 22, 2023

burnout87 commented Nov 22, 2023

rokroskar commented Nov 28, 2023

burnout87 commented Nov 29, 2023

burnout87 commented Dec 18, 2023

rokroskar Dec 18, 2023

volodymyrss Dec 20, 2023

rokroskar Dec 18, 2023


		USER oda

		ENTRYPOINT bash -c 'export HOME_OVERRRIDE=/tmp/jovyan; mkdir $HOME_OVERRRIDE; cd /tmp/jovyan; source /init.sh; jupyter lab --ip 0.0.0.0 --no-browser'

		@@ -0,0 +1,23 @@
		#!/bin/bash

		export HOME_OVERRRIDE=/tmp/jovyan;

mmoda/smartsky templates (with icons!) #16

Are you sure you want to change the base?

mmoda/smartsky templates (with icons!) #16

Conversation

volodymyrss commented Sep 7, 2022 • edited Loading

rokroskar left a comment

Choose a reason for hiding this comment

rokroskar Jul 3, 2023

Choose a reason for hiding this comment

burnout87 Nov 22, 2023

Choose a reason for hiding this comment

volodymyrss Dec 20, 2023

Choose a reason for hiding this comment

rokroskar commented Oct 5, 2023

volodymyrss commented Oct 5, 2023

rokroskar commented Oct 5, 2023

burnout87 commented Oct 10, 2023 • edited Loading

burnout87 commented Nov 22, 2023

burnout87 commented Nov 22, 2023

rokroskar commented Nov 28, 2023

burnout87 commented Nov 29, 2023

burnout87 commented Dec 18, 2023

rokroskar Dec 18, 2023

Choose a reason for hiding this comment

volodymyrss Dec 20, 2023

Choose a reason for hiding this comment

rokroskar Dec 18, 2023

Choose a reason for hiding this comment

volodymyrss commented Sep 7, 2022 •

edited

Loading

burnout87 commented Oct 10, 2023 •

edited

Loading