Add scaled(toMaxSize:NSSize) to NSImage, including a test

[buddax2]

Add a function to NSImage to be able to scale an image to some maximum size. It could be useful for creating thumbnails.

Checklist

• I checked the Contributing Guidelines before creating this request.
• New extensions are written in Swift 4.
• New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
• I have added tests for new extensions, and they passed.
• All extensions have a clear comments explaining their functionality, all parameters and return type in English.
• All extensions are declared as public.

[SwifterSwiftBot]

	1 Message
📖	Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

[codecov]

Codecov Report

Merging #291 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   94.41%   94.56%   +0.15%     
==========================================
  Files          99      100       +1     
  Lines        5494     5555      +61     
==========================================
+ Hits         5187     5253      +66     
+ Misses        307      302       -5

Flag	Coverage Δ
#ios	94.35% <ø> (+0.14%)	⬆️
#osx	61.18% <100%> (+0.52%)	⬆️
#tvos	89.31% <ø> (+0.19%)	⬆️

Impacted Files	Coverage Δ
Tests/AppKitTests/NSImageExtensionsTests.swift	100% <100%> (ø)
...es/Extensions/SwiftStdlib/OptionalExtensions.swift	100% <0%> (ø)	⬆️
Tests/FoundationTests/DateExtensionsTests.swift	94.97% <0%> (+0.26%)	⬆️
Sources/Extensions/Foundation/DateExtensions.swift	100% <0%> (+1.71%)	⬆️
...sts/SwiftStdlibTests/OptionalExtensionsTests.swift	93.93% <0%> (+5.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c67b5d...cfd8997. Read the comment docs.

[SD10]

public func scaled(to maxSize: NSSize) -> NSImage may be better?

[SD10]

actually maybe not, loses the expressiveness of it being a max size.

[SD10]

Thank you for your contribution @buddax2. Can you add a CHANGELOG entry for this?

[buddax2]

@SD10 sure I can. Should I add a new release section for this (v4.0.2)?

[SD10]

No @buddax2 It just goes under the Next Release section. Follow the previous CHANGELOG as a guide

EDIT: Can you also add an entry for #296? We forgot this one 😅

[buddax2]

@SD10 can I add an entry for #296 in this PR? :)

[SD10]

Sure things @buddax2 👍

[buddax2]

@SD10 done

[SD10]

Thank you for your contribution @buddax2 Sorry for the delay!

[omaralbeik]

Thank you @buddax2 @SD10 👍