Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useful Core Data extensions #273

Merged
merged 4 commits into from
Oct 7, 2017

Conversation

MaxHaertwig
Copy link
Contributor

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 4.
  • New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.

@SwifterSwiftBot
Copy link

SwifterSwiftBot commented Oct 4, 2017

1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Oct 4, 2017

Codecov Report

Merging #273 into master will increase coverage by 0.33%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   54.86%   55.19%   +0.33%     
==========================================
  Files          46       47       +1     
  Lines        3292     3323      +31     
==========================================
+ Hits         1806     1834      +28     
- Misses       1486     1489       +3
Impacted Files Coverage Δ
...s/FoundationTests/NSPredicateExtensionsTests.swift 100% <100%> (ø)
Tests/UIKitTests/UILabelExtensionsTests.swift 0% <0%> (ø) ⬆️
Tests/SwiftStdlibTests/BoolExtensionsTests.swift 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15fc96f...5634f7a. Read the comment docs.

@omaralbeik omaralbeik requested a review from SD10 October 5, 2017 06:22
import Foundation

// MARK: - Methods
public extension NSPredicate {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NSPredicate is actually a Foundation type 🤔

@SD10
Copy link
Member

SD10 commented Oct 5, 2017

Thank you @Vyax 👍 I'd probably be more willing to accept the NSPredicate extensions and drop what pertains to Core Data. We'd need another subspec and we don't have any other Core Data extensions. TBH, I'd like to steer away from anything outside of UIKit/Foundation/Cocoa/CoreGraphics 🤔

@MaxHaertwig
Copy link
Contributor Author

I removed the NSFetchRequest extensions and moved the NSPredicate extensions to Foundation.

@omaralbeik omaralbeik merged commit a845df4 into SwifterSwift:master Oct 7, 2017
@MaxHaertwig MaxHaertwig deleted the core-data branch October 7, 2017 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants