fix(effects): Fix parameters of effect not showing up when not in def…

…ault settings file fixes mixxxdj/issues/10834
Swiftb0y · Sep 19, 2022 · 9b5c085 · 9b5c085
1 parent f8a7d7b
commit 9b5c085
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/effects/presets/effectpresetmanager.cpp b/src/effects/presets/effectpresetmanager.cpp
@@ -39,11 +39,13 @@ void EffectPresetManager::loadDefaultEffectPresets() {
             file.close();
             continue;
         }
-        EffectPresetPointer pEffectPreset(new EffectPreset(doc.documentElement()));
-        if (!pEffectPreset->isEmpty()) {
+        auto presetFromFile = EffectPreset(doc.documentElement());
+        if (!presetFromFile.isEmpty()) {
             EffectManifestPointer pManifest = m_pBackendManager->getManifest(
-                    pEffectPreset->id(), pEffectPreset->backendType());
+                    presetFromFile.id(), presetFromFile.backendType());
             if (pManifest) {
+                auto pEffectPreset = EffectPresetPointer(new EffectPreset(pManifest));
+                pEffectPreset->updateParametersFrom(presetFromFile);
                 m_defaultPresets.insert(pManifest, pEffectPreset);
             }
         }