Skip to content
This repository has been archived by the owner on Mar 26, 2023. It is now read-only.

[81] Issue #81 - August 3, 2017 #293

Closed
jessesquires opened this issue Jul 27, 2017 · 9 comments
Closed

[81] Issue #81 - August 3, 2017 #293

jessesquires opened this issue Jul 27, 2017 · 9 comments
Assignees

Comments

@jessesquires
Copy link
Member

To contribute to this issue, simply leave a comment here. Please also review our contributing guidelines.

The current draft for this issue in _drafts/. If you want to contribute directly, open a pull request.

@jessesquires jessesquires self-assigned this Jul 27, 2017
jessesquires added a commit that referenced this issue Jul 27, 2017
@jessesquires
Copy link
Member Author

@jessesquires
Copy link
Member Author

@BasThomas
Copy link
Contributor

@jessesquires
Copy link
Member Author

@marcelofabri
Copy link

Sorry for the shameless plug, but swiftlang/swift#11264 fixed https://bugs.swift.org/browse/SR-2487 which was a quite popular SR. 🎉

@jessesquires
Copy link
Member Author

@marcelofabri this is great! 🥇 do you think you could explain this a bit more? 😅

@jessesquires
Copy link
Member Author

@marcelofabri
Copy link

@jessesquires Swift 2.3 removed the "source.decl.attribute.__raw_doc_comment" attribute from structures returned by SourceKit. This was used by SwiftLint to implement ValidDocsRule and MissingDocsRule.

That PR not only restores the functionality, but takes a step further and adds the range of a doc comment for each declaration. This would make possible to add back those rules (and their implementation could possibly even be simpler now).

jessesquires added a commit that referenced this issue Aug 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants