Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear port is performed before (and thus outside) the connect() function of a driver #37

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Clear port is performed before (and thus outside) the connect() function of a driver #37

merged 5 commits into from
Mar 12, 2024

Conversation

fk3
Copy link
Contributor

@fk3 fk3 commented Mar 12, 2024

  • clear() is called immediately after a port is opened by the Port Manager
  • connect() of EmptyDevice does not do anything
  • use self.port_properties["clear"] = False to disable running clear() on the port

@fk3 fk3 requested a review from a team as a code owner March 12, 2024 15:32
@fk3 fk3 merged commit 1729bf3 into main Mar 12, 2024
3 checks passed
@fk3 fk3 deleted the clear-port branch March 12, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afischer-sweepme afischer-sweepme afischer-sweepme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fk3 @afischer-sweepme