Replaces Sort by ID with Date Added #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabhirav
force-pushed
the
sort-by-date-added
branch
from
f71b3a1 to
182d19a
Compare
schroda
approved these changes
Mar 4, 2023
Yeah, sorry about that. I was getting lazy and included it here since it was a small file change |
|
no worries, if you're lazy, what am I then 😆, look at all your PR descriptions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort by Date Added
This sort helps you find the latest manga you've added to your Library
Why replace Sort by ID
Sort by ID, sorted the manga with an internally generatec ID in backend. This is not at all helpful for users as this might seem very random to them and is random for intents and purposes for them. This sort can used in best case for debugging, but there are better ways for that.
Updating the IManga type
This PR also updates the IManga type with all the latest data that it's getting from the backend. This can be very helpful for features that are planned for the future
.nvmrc
This PR also adds ,nvmrc so it's easier for developers to switch to the relevant node version while developing and testing