Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup library #107

Merged
merged 2 commits into from
Nov 19, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export default function App() {
<Route path="/manga/:id">
<Manga />
</Route>
<Route path="/library/:tabParamNumber?">
<Route path="/library">
<Library />
</Route>
<Route path="/updates">
Expand Down
1 change: 0 additions & 1 deletion src/components/navbar/DefaultNavBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ export default function DefaultNavBar() {
<Toolbar>
{
!navbarItems.some(({ path }) => path === history.location.pathname)
&& !history.location.pathname.startsWith('/library')
&& (
<IconButton
edge="start"
Expand Down
27 changes: 11 additions & 16 deletions src/screens/Library.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import TabPanel from 'components/util/TabPanel';
import LibraryOptions from 'components/library/LibraryOptions';
import LibraryMangaGrid from 'components/library/LibraryMangaGrid';
import LibrarySearch from 'components/library/LibrarySearch';
import { useHistory, useParams } from 'react-router-dom';
import { useQueryParam, NumberParam } from 'use-query-params';

interface IMangaCategory {
category: ICategory
Expand All @@ -35,21 +35,18 @@ export default function Library() {
);
}, []);

const { tabParamNumber } = useParams<{ tabParamNumber: string }>();
const [tabs, setTabs] = useState<IMangaCategory[]>();

const [tabNum, setTabNum] = useState<number>(0);
const history = useHistory();
const [tabSearchParam, setTabSearchParam] = useQueryParam('tab', NumberParam);

// a hack so MangaGrid doesn't stop working. I won't change it in case
// if I do manga pagination for library..
const [lastPageNum, setLastPageNum] = useState<number>(1);

const handleTabChange = (newTab: number) => {
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
history.location.search === ''
? history.replace(`/library/${newTab}`)
: history.replace(`/library/${newTab}/${history.location.search}`);
setTabNum(newTab);
setTabSearchParam(newTab);
};

useEffect(() => {
Expand All @@ -63,15 +60,13 @@ export default function Library() {
}));
setTabs(categoryTabs);
if (categoryTabs.length > 0) {
setTabNum(() => {
if (tabParamNumber !== undefined
&& !Number.isNaN(tabParamNumber)
&& !!categories.find((cat) => cat.order === Number(tabParamNumber))) {
AriaMoradi marked this conversation as resolved.
Show resolved Hide resolved
return Number(tabParamNumber);
}
history.replace('/library');
return categoryTabs[0].category.order;
});
if (
tabSearchParam !== undefined
&& tabSearchParam !== null
&& !Number.isNaN(tabSearchParam)
) {
handleTabChange(Number(tabSearchParam!));
} else { handleTabChange(categoryTabs[0].category.order); }
}
});
}, []);
Expand Down
23 changes: 6 additions & 17 deletions src/util/useLibraryOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*/

import { BooleanParam, useQueryParams, StringParam } from 'use-query-params';
import { BooleanParam, useQueryParam, StringParam } from 'use-query-params';

export type NullAndUndefined<T> = T | null | undefined;

Expand All @@ -21,24 +21,13 @@ interface IUseLibraryOptions {
}

export default function useLibraryOptions(): IUseLibraryOptions {
const [searchQuery, setSearchQuery] = useQueryParams({
downloaded: BooleanParam,
unread: BooleanParam,
query: StringParam,
});
const { downloaded, unread, query } = searchQuery;
const setDownloaded = (newDownloaded: NullAndUndefined<boolean>) => {
setSearchQuery(Object.assign(searchQuery, { downloaded: newDownloaded }), 'replace');
};
const setUnread = (newUnread: NullAndUndefined<boolean>) => {
setSearchQuery(Object.assign(searchQuery, { unread: newUnread }), 'replace');
};
const setQuery = (newQuery: NullAndUndefined<string>) => {
setSearchQuery(Object.assign(searchQuery, { query: newQuery }), 'replace');
};
const [downloaded, setDownloaded] = useQueryParam('downloaded', BooleanParam);
const [unread, setUnread] = useQueryParam('unread', BooleanParam);
const [query, setQuery] = useQueryParam('query', StringParam);

// eslint-disable-next-line eqeqeq
const active = !(unread == undefined) || !(downloaded == undefined);
return {
downloaded, setDownloaded, unread, setUnread, active, query, setQuery,
downloaded, setDownloaded, unread, setUnread, query, setQuery, active,
};
}