Add support for configuring which categories are downloaded automatically #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chance Zibolski <[email protected]>
schroda
reviewed
Jan 17, 2024
chancez
force-pushed
the
configure_category_downloads
branch
from
0525d29 to
dabd42b
Compare
Syer10
approved these changes
Jan 19, 2024
schroda
reviewed
Jan 20, 2024
chancez
force-pushed
the
configure_category_downloads
branch
from
dabd42b to
157e6e2
Compare
chancez
force-pushed
the
configure_category_downloads
branch
3 times, most recently
from
0515e64 to
1290995
Compare
…ally If a manga has no configured categories, behavior remains the same and the automatic download functionality will download new chapters without consulting the category includeInDownload configuration. Signed-off-by: Chance Zibolski <[email protected]>
chancez
force-pushed
the
configure_category_downloads
branch
from
1290995 to
b31c342
Compare
schroda
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation is similar to the global update categories. This allows you to configure which manga you want to auto download based on their categories. The default behavior remains the same. If no categories are configured, then automatic downloads will behave the same as prior to this change, which is to say, all manga in your library are considered for automatic downloads.
The idea is that you might have
server.excludeEntryWithUnreadChapters=falsebut don't necessarily want all your manga to get downloaded when new chapters come out.For example; if you've started a manga, but are taking a break, or if you finished a manga that has some "extra" chapters that come out later, or something. For a setup like this, I have a "currently reading" category, and a "backlog" and "completed" category". I'd set "currently reading" to be included, and the others to be excluded, ensuring only manga in my "currently reading" get auto downloaded as new chapters are released.