Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/backup import failure not resetting status #746

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Fix/backup import failure not resetting status #746

merged 7 commits into from
Nov 1, 2023

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Oct 30, 2023

No description provided.

Syer10
Syer10 reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@Syer10 Syer10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to do this? This is a breaking change to the backup models in the scheme

@schroda
Copy link
Collaborator Author

schroda commented Oct 31, 2023 •
edited
Loading

not sure tbh

only having an Idle status does not work for detecting if it failed or succeded.
and once the Idle status gets replaced with Failure and Success you can't reset to Idle anymore, since you have to pull for the restore status, and thus, setting it to Idle could lead to never getting the Failure or Success status

@schroda schroda force-pushed the fix/backup_import_failure_not_resetting_status branch from a2b7807 to 6c2b799 Compare October 31, 2023 19:11
@schroda
Reset backup status to idle in case of an exception
cc3fb1a
@schroda
Rename "performRestore" function
359feb1
@schroda
Set backup status to failure on exception
e78d3bd 
Makes it possible to detect if the restore failed or not after the first status was received
@schroda
Set backup status to success on completion
2a01334 
Since the status is not provided over a subscription, but over a query that should be pulled, it is not really easily detectable if a restore finished or not, since both states will be indicated by "idle"
@schroda
Correctly wait for first new status when triggering backup import
8c5f144 
The status is only "Idle" in case no backup import has ever run.
Once the first backup process finished it is either "Failure" or "Success"
@schroda
Rename "ProtoBackupImport::restore" function
bf6d6aa
@schroda schroda force-pushed the fix/backup_import_failure_not_resetting_status branch from 6c2b799 to de9401e Compare October 31, 2023 19:16
@schroda
Add id to restore process
4005e40 
Makes it possible to differentiate between backup restore processes.
@schroda schroda force-pushed the fix/backup_import_failure_not_resetting_status branch from de9401e to 4005e40 Compare October 31, 2023 19:21
@Syer10 Syer10 merged commit 7ed8f43 into Suwayomi:master Nov 1, 2023
2 checks passed
@schroda schroda deleted the fix/backup_import_failure_not_resetting_status branch November 1, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syer10 Syer10 Syer10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schroda @Syer10