Fix/updater update stuck in running status after failure #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroda
force-pushed
the
fix/updater_update_stuck_in_running_status_after_failure
branch
from
7c390ca to
9b7fb81
Compare
Syer10
reviewed
Oct 29, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/update/Updater.kt
Outdated
Show resolved
Hide resolved
In case the channel failed due to an exception, the update for the source failed completely. This however was never handled and the pending updates for the source were never set to failed. Due to this, the global updates running state was always true
schroda
force-pushed
the
fix/updater_update_stuck_in_running_status_after_failure
branch
from
9b7fb81 to
b718253
Compare
Syer10
approved these changes
Oct 30, 2023
schroda
deleted the
fix/updater_update_stuck_in_running_status_after_failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the channel failed due to an exception, the update for the source failed completely.
This however was never handled and the pending updates for the source were never set to failed.
Due to this, the global updates running state was always true