Fix/downloader #622
Merged
Fix/downloader #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unclear why it was converted to Long since it just got converted back to String anyway when it was used in the Downloader
The downloader just changed the state of all downloads, ignoring if they are from the source the Downloader is for or not
In case chapters were added to the queue the DownloadManager will start itself
In case nothing was done there is nothing to notify about
schroda
force-pushed
the
fix/downloader
branch
3 times, most recently
from
7cdc07e to
96f88eb
Compare
In case there were failed chapter downloads in the queue the DownloadManager still created a Downloader and started it. This Downloader would than immediately call "onComplete", since there is no available download, which then would refresh the Downloaders again which created an infinite loop until the failed download got removed from the queue
In case a failed downloaded that was still in the queue was tried to get added to the queue again, nothing happened. Instead of doing nothing, the download should get retried. Thus, it also provides the logic to easily retry a failed download by just "adding" the chapter to the queue again. Currently, to retry a failed download, the download has to be removed from the queue and then get re-added.
Syer10
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.