Fix/ha scheduler rescheduling ha tasks #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroda
force-pushed
the
fix/ha_scheduler_rescheduling_ha_tasks
branch
from
e5e8bff to
7af86d1
Compare
schroda
force-pushed
the
fix/ha_scheduler_rescheduling_ha_tasks
branch
from
7af86d1 to
776870d
Compare
In case an initial delay is used for "Timer::scheduleAtFixedRate" (e.g. when rescheduling) then the "firstExecutionTime" of the "HATask" was incorrect, since it considered the first execution to be based on the actual interval. This caused - calculations for execution times (e.g. "timeToNextExecution", "nextExecutionTime") to be incorrect - the ordering of the "scheduledTasks" queue to be incorrect
schroda
force-pushed
the
fix/ha_scheduler_rescheduling_ha_tasks
branch
from
776870d to
4f26880
Compare
schroda
force-pushed
the
fix/ha_scheduler_rescheduling_ha_tasks
branch
from
7ca5969 to
a868fc6
Compare
Caused a "ConcurrentModificationException" and broke the system suspension detection due to the unhandled exception canceling the task
In case an exception is uncaught/unhandled, it only gets logged in the console, but is not included in the log file. E.g. the "HAScheduler::scheduleHibernateCheckerTask" task caused an unhandled "ConcurrentModificationException" which caused the task to get dropped. In the log files this error could not be seen and thus, analysing the issue of the suspension detection to stop working was not possible via the logs
The missed execution was never triggered
When scheduling a task for the first time, the "first execution time" is in the future. This time is used for by all functions calculating times for this task (e.g. next/last execution time). In case the first execution didn't happen yet and the current time, would have been an "execution time" based on the interval, the "hibernation detection" would trigger for this task, since it would think that the last execution was missed, due to the "last execution" being in the future. To prevent this, it has to be made sure, that the "last execution time" is in the past.
schroda
force-pushed
the
fix/ha_scheduler_rescheduling_ha_tasks
branch
from
a868fc6 to
eded283
Compare
Syer10
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.