Fix random page sent when book is downloaded #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabhirav
force-pushed
the
fix-random-page-when-downloaded
branch
2 times, most recently
from
455ef22 to
a1c48dd
Compare
akabhirav
force-pushed
the
fix-random-page-when-downloaded
branch
from
a1c48dd to
dac5ffd
Compare
|
fixes #528 |
|
More like fix-ed we won't close that one as we'll won't have a future stable release of Tachidesk in a few months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes random pages being sent when a chapter is downloaded
Steps to reproduce
Expected behaviour
The pages should render in correct order
Current behaviour
The pages are getting rendered randomly
The problem was the files were not being sorted before being read and sent. Now that's fixed