Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic android.graphics Rect and Canvas implementation #461

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

animeavi
Copy link
Contributor

@animeavi animeavi commented Dec 5, 2022

Some extensions use more Canvas methods, but they don't really seem to get that far yet, all the others I was able to test seem to work now.

This fixes both extensions mentioned in #444 and a couple more I was able to test, in the future Canvas will need more stuff implemented but I can't even test that yet because the extensions have other problems and don't really get to those calls.

@Syer10
Copy link
Collaborator

Syer10 commented Dec 5, 2022

Can you give a list of extensions you were able to get working and ones what you were not?

@animeavi
Copy link
Contributor Author

animeavi commented Dec 5, 2022

Can you give a list of extensions you were able to get working and ones what you were not?

I'll retest the others in a bit, I must have tested something in 禁漫天堂 / Jinman Tiantang that didn't use WEBP before cause that seems to be the problem now, I'll see if just bringing in the TwelveMonkeys WEBP library for ImageIO fixes it, since we already use it for JPEG anyway.

Some extensions use more Canvas methods, but they don't
really seem to get that far yet, all the others I was
able to test seem to work now.
@animeavi
Copy link
Contributor Author

animeavi commented Dec 6, 2022

Ok seems like some WEBPs from Jinman Tiantang can be decoded and some can't, I don't know if it's done on purpose or if it can be fixed, so I'd say that one partially works for now.

@animeavi
Copy link
Contributor Author

animeavi commented Dec 6, 2022

From my tests of the extensions that use Canvas.

Working:

  • MangaReader.to
  • dmzj / 动漫之家 (looks like unimplemented Canvas is used for "comments" but not for getting pages)
  • 肉漫屋 / Roumanwu
  • Webtoons.com
  • Web Comic Gamma(+ Plus)
  • Flame Scans
  • GigaViewer (tested Comic Days)
  • Hentai2Read

Partially working:

  • 禁漫天堂 / Jinman Tiantang (random WEBP decoding issue)

Not working:

  • Viz Shonen Jump (com.drew.imaging.ImageProcessingException: File format could not be determined, uses unimplemented Canvas also)
  • Tapas.io (some unimplemented cookie feature, uses unimplemented Canvas)
  • xCaliBR Scans (javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version)
  • Japscan (some stub related to android.os.Looper.getMainLooper)

Copy link
Collaborator

@Syer10 Syer10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@AriaMoradi AriaMoradi merged commit d9c6f52 into Suwayomi:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants