Refactor: Align Extension Methods with Project Structure and Remove Unused Usings #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to align with project structure and Removed all unused using statements.
AndersAbel
requested changes
Jun 12, 2024
| using Sustainsys.Saml2.Bindings; | ||
| using Sustainsys.Saml2.Serialization; | ||
|
|
||
|
|
||
| // By convention, the extension methods are placed in the Microsoft shared | ||
| // namespace to allow convenient access from intellisense. | ||
| namespace Microsoft.Extensions.DependencyInjection; |
There was a problem hiding this comment.
The AddSaml2() methods should be in the Microsoft.Extensions.DependcyInjection namespace. This aligns with how the Microsoft supplied handlers work - they put their Add* methods in that namespace even though the rest of the code is in Microsoft.AspNetCore.Authentication.*
|
|
||
| namespace Microsoft.Extensions.DependencyInjection; | ||
| namespace Sustainsys.Saml2.AspNetCore; |
There was a problem hiding this comment.
This one is correct, the PostConfigure should be in our namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of Unused Using Statements: To improve code readability and maintainability, all unused using statements have been removed from the project files.
Reorganization of Extension Methods: The extension methods have been moved to the Sustainsys.Saml2.AspNetCore namespace. This change aligns the location of these methods with the overall project structure, making the codebase easier to navigate and understand.
These changes do not affect the functionality of the code but contribute to cleaner and more organized codebase.