Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI support for YAML output #53

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Add CLI support for YAML output #53

merged 1 commit into from
Jan 17, 2017

Conversation

mandrean
Copy link
Contributor

Basically adds support for ./bin/swagger-jsdoc -o output.yaml.

@kalinchernev
Copy link
Contributor

Hi @mandrean thanks for this suggestion!
I tested the feature and the code changes look fine, however the output file that I got was actually a json file with a yml extension.
The environment that I'm using for the test is regular cloud9 ubuntu machine:
swagger_spec_yml

@mandrean
Copy link
Contributor Author

@kalinchernev Really? Wtf. It works fantastically well for us on a project... Need to investigate further.

skarmavbild 2017-01-14 kl 16 38 32

skarmavbild 2017-01-14 kl 16 38 47

Copy link
Contributor

@kalinchernev kalinchernev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing with .yml, not .yaml, which works well.

@mandrean
Copy link
Contributor Author

Ah @kalinchernev! I should probably add .yml to the check as well then.

@kalinchernev
Copy link
Contributor

It could be nice,yes :) Although not required, as the .yaml is the recommended one.

@mandrean
Copy link
Contributor Author

@kalinchernev Done! :)

@kalinchernev
Copy link
Contributor

@mandrean thank you!
@drGrove could you have a look if you have any other feedback on this one?
I consider this pull request ready to be merged.

@kalinchernev kalinchernev merged commit 9c4f05e into Surnet:master Jan 17, 2017
@kalinchernev
Copy link
Contributor

@drGrove @mandrean thanks!

@mandrean mandrean deleted the feat/yaml-output branch January 17, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants