Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deprecation check #45

Merged
merged 2 commits into from
Dec 29, 2016
Merged

Ignore deprecation check #45

merged 2 commits into from
Dec 29, 2016

Conversation

toefraz
Copy link
Contributor

@toefraz toefraz commented Dec 10, 2016

References issue #44

Ignores deprecation checks if property is a direct child of a 'properties' object.

Ignores deprecation checks if property is a direct child of a 'properties' object.
@kalinchernev
Copy link
Contributor

Hi @toefraz looks nice, thanks!
Do you mind making a test for this to have a notion of the scenario? There is a set of tests that you can extend with some example data that you have in your case.
Otherwise, all looks fine!

@kalinchernev
Copy link
Contributor

@toefraz could you please share an example of your use case?

@toefraz
Copy link
Contributor Author

toefraz commented Dec 20, 2016

@kalinchernev sorry for not responding sooner; I've been very busy. I will update this over the next couple of days. Thanks!

Deprecated property names should display a warning only if they are not used inside "properties" objects.
@toefraz
Copy link
Contributor Author

toefraz commented Dec 22, 2016

@kalinchernev Just added some tests to verify this is working. Let me know what you think

Copy link
Contributor

@kalinchernev kalinchernev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @toefraz looks good to me, thanks!
@drGrove any comments?

@drGrove
Copy link
Contributor

drGrove commented Dec 23, 2016

LGTM, did circle run?

@kalinchernev
Copy link
Contributor

No, in fact it hasn't. Could you it be because of my last commit upgrading packages?
Checking the circleci site, this is the last thing before it stops...

@kalinchernev kalinchernev changed the base branch from master to develop December 24, 2016 10:30
@kalinchernev kalinchernev changed the base branch from develop to master December 24, 2016 10:30
@kalinchernev
Copy link
Contributor

Hi @drGrove I checked the circleci settings and noticed that this option was off:

project settings surnet swagger jsdoc circleci

Switched it on, updated the develop, tried to trigger the build switching the target branch but it didn't run.

@toefraz could you please make some tiny update on your code just to push a change to trigger the CI? Apologies for this, but I don't know why it hasn't run so far..

@kalinchernev
Copy link
Contributor

Just sharing further tests about the circle ci, opening a new test pull request, the build ran ok, I don't really know what might be the reason for previous commits not running the CI.

@kalinchernev kalinchernev merged commit 2d67281 into Surnet:master Dec 29, 2016
@kalinchernev
Copy link
Contributor

Hi @toefraz your suggestion is merged - thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants