-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore deprecation check #45
Conversation
Ignores deprecation checks if property is a direct child of a 'properties' object.
Hi @toefraz looks nice, thanks! |
@toefraz could you please share an example of your use case? |
@kalinchernev sorry for not responding sooner; I've been very busy. I will update this over the next couple of days. Thanks! |
Deprecated property names should display a warning only if they are not used inside "properties" objects.
@kalinchernev Just added some tests to verify this is working. Let me know what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, did circle run? |
No, in fact it hasn't. Could you it be because of my last commit upgrading packages? |
Hi @drGrove I checked the circleci settings and noticed that this option was off: Switched it on, updated the develop, tried to trigger the build switching the target branch but it didn't run. @toefraz could you please make some tiny update on your code just to push a change to trigger the CI? Apologies for this, but I don't know why it hasn't run so far.. |
Just sharing further tests about the circle ci, opening a new test pull request, the build ran ok, I don't really know what might be the reason for previous commits not running the CI. |
Hi @toefraz your suggestion is merged - thanks for your work! |
References issue #44
Ignores deprecation checks if property is a direct child of a 'properties' object.