Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sample to comply with Swagger v2 #42

Merged
merged 1 commit into from
Nov 18, 2016
Merged

Updating sample to comply with Swagger v2 #42

merged 1 commit into from
Nov 18, 2016

Conversation

cikasfm
Copy link
Contributor

@cikasfm cikasfm commented Nov 17, 2016

I had to spend quite some time to figure out what was wrong with my code. Apparently, the sample had a deprecated property definition, now should bedefinitions

@kalinchernev
Copy link
Contributor

Hi @cikasfm thanks for this pull request, using definition should still be a working scenario for you, could you please check which version are you using? In v1.8.1 both singular and plural forms should be acceptable and the singular should yield a warning of future deprecation. Could you verify that please?
I have no issues merging this, just wondering if you have latest version and would be notified for future deprecation as intended.

@cikasfm
Copy link
Contributor Author

cikasfm commented Nov 18, 2016

Hi @kalinchernev! Yes, it does work using definition but keeps printing a deprecation warning. It took me quite a while to figure out why this is happening ( up to debugging your code... :) for whatever reason I didn't 'see' this earlier... ) so when I understood that the problem was in the sample I thought it would make sense to update the sample itself.

I actually was using v1.8.1 at the time of writing.

@kalinchernev kalinchernev merged commit 6e97767 into Surnet:master Nov 18, 2016
@kalinchernev
Copy link
Contributor

@cikasfm I see ... thanks! :)
PS And sorry for the trouble you had to debug this!

@cikasfm
Copy link
Contributor Author

cikasfm commented Nov 18, 2016

Sure, you're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants