Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'api' attr from swagger definition #234

Merged
merged 2 commits into from
Dec 12, 2020

Conversation

mits87
Copy link
Contributor

@mits87 mits87 commented Dec 10, 2020

Fix the problem with not necessary api attribute inside the swaggerDefinition file:
Issue: #233

@kalinchernev
Copy link
Contributor

@mits87 thanks for taking the time to fix this! The pull request is ok, only 1 request: please update the documentation as briefly mentioned at #233 (comment)

lastly, a small doc update to remove the apis mention from https://github.com/Surnet/swagger-jsdoc/blob/master/docs/CLI.md#definition-file and remove When you don't want to or can't pass apis from the definition above, specify like following:

@mits87
Copy link
Contributor Author

mits87 commented Dec 12, 2020

@kalinchernev Done

@kalinchernev kalinchernev merged commit 863ee2c into Surnet:master Dec 12, 2020
@kalinchernev
Copy link
Contributor

@mits87 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants