Add empty array fallback to regex match #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no results are found `match` returns `null`. When we try to iterate over the resulting `null`, we get a type error. This adds an empty array fallback to prevent that error. developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match#Return_value
|
I added some tests that needed some additional files, so I added a |
kalinchernev
approved these changes
Nov 28, 2020
|
@evans thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating this! When extracting annotations and no doc strings are found,
matchreturnsnull. When we try to iterate over the resultingnull, we get a type error. This adds an empty array fallback to prevent that error and exit.I thought about adding a warning that no docs were found here, though handling that in the caller seems more appropriate. Let me know if you'd prefer that to happen here!
reference for
matchhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match#Return_value