Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] options.api allows glob strings #20

Merged
merged 6 commits into from
Apr 7, 2016
Merged

[WIP] options.api allows glob strings #20

merged 6 commits into from
Apr 7, 2016

Conversation

jonboiser
Copy link
Contributor

Re: #19

This is my first pass at the glob feature. Since the glob library handles non-glob strings perfectly fine, I simply map-reduce the whole apis array through glob, and then pass the resulting array into the for-loop.

Tests still pass, but I'm not sure if a spec was written for this part of the code.

@jonboiser
Copy link
Contributor Author

I did a test replacing ./example/routes.js with ./example/*.js in example/app.js. I could extend the example app to illustrate the original use case I put in the original issue.

@jonboiser
Copy link
Contributor Author

I extended the example app to cover this new glob use case. It may not be the most elegant way to extend it, though.

@chdanielmueller
Copy link
Member

Hi @jonboiser,
I did take a look at your implementation and it seems fine to me.

But I would like some little changes:
Please remove the definition Login2 from the routes2.js (and also from the swagger-spec.json):

  /**
   * @swagger
   * definition:
   *   Login2:
   *     required:
   *       - username
   *       - password
   *     properties:
   *       username:
   *         type: string
   *       password:
   *         type: string
   */

And please update the version from 1.2.1 to 1.3.0 in the package.json.

After you have done that I will merge and publish your changes.
Thank you,
Daniel

@jonboiser
Copy link
Contributor Author

Done!

@chdanielmueller chdanielmueller merged commit 7d9aa00 into Surnet:master Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants